Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added system include path auto-discovery #1455

Merged
merged 7 commits into from
Oct 14, 2021
Merged

Added system include path auto-discovery #1455

merged 7 commits into from
Oct 14, 2021

Conversation

max-leuthaeuser
Copy link
Contributor

No description provided.

@max-leuthaeuser max-leuthaeuser marked this pull request as ready for review October 12, 2021 12:44
fabsx00
fabsx00 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@fabsx00 fabsx00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that was quick! I think this should probably be the default even, but let's merge it first and try it out.

@max-leuthaeuser max-leuthaeuser merged commit 81eaca6 into master Oct 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the max/includeAutodiscovery branch October 14, 2021 12:27
fabsx00 added a commit that referenced this pull request Oct 15, 2021
@fabsx00
Revert "Added system include path auto-discovery (#1455)"
1f92124 
This reverts commit 81eaca6.
fabsx00 added a commit that referenced this pull request Oct 16, 2021
@fabsx00
Revert header auto discovery and fix NPE (#1468)
97a502b 
* Revert "Added system include path auto-discovery (#1455)"

This reverts commit 81eaca6.

* Fix NPE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabsx00 fabsx00 fabsx00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-leuthaeuser @fabsx00