Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give out all images in api. #631

Closed
CuddleBear92 opened this issue Jun 18, 2017 · 5 comments
Closed

give out all images in api. #631

CuddleBear92 opened this issue Jun 18, 2017 · 5 comments
Assignees
@bigretromike
Labels
Enhancement - API

Comments

@CuddleBear92
Copy link

coming from Cazzar/ShokoMetadata.bundle#9
we need the Shoko server API to support giving out all the images the server has.

right now it gives out only one cover and one fanart i believe. giving the api users (plex metadata) few choices compared to the rest.
@CuddleBear92 CuddleBear92 mentioned this issue Jun 18, 2017
Closed
@bigretromike
Copy link
Contributor

Its good idea, but im it would need to have a proper tag so the plugin/addon developer can pick if he want to wait longer for all images to get listed or not. because it would be a bad idea by default to throw all images for filters like All and it would be silly just to throw all images just for serie when you already inside it.

@bigretromike bigretromike self-assigned this Jun 28, 2017
bigretromike added a commit that referenced this issue Jun 28, 2017
@bigretromike
added 'give out all images in api. #631';
3f7aa18
@bigretromike
Copy link
Contributor

This should give developer option to pick allpic, number of pic or default is back-compatible which is 1 for fanart and 1 for banner.

@Cazzar
Copy link
Member

Cazzar commented Aug 9, 2017

allpics=1 doesn't seem to load all posters.

@Cazzar Cazzar reopened this Aug 9, 2017
@Cazzar
Copy link
Member

Cazzar commented Aug 9, 2017

image

@Cazzar
Copy link
Member

Cazzar commented Aug 27, 2017

425e6ea

@Cazzar Cazzar closed this as completed Aug 27, 2017
Cazzar pushed a commit to maxpiva/ShokoServer that referenced this issue Feb 7, 2018
@bigretromike
added 'give out all images in api. ShokoAnime#631';
fbdcc3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigretromike bigretromike

Labels
Enhancement - API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Cazzar @bigretromike @CuddleBear92 @ElementalCrisis