Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AniDB Mylist watched status reset after re-importing files #770

Closed
hidden4003 opened this issue Jan 3, 2019 · 10 comments

Comments

@hidden4003
Copy link
Member

commented Jan 3, 2019

VERSION INFORMATION

Server Version: 3.9.3 ? commit hash 5715c3b
Desktop Version: 3.9.3

If you've compiled your own version, please use the last commit you compiled.

LOG FILE

2018-12-27-log.txt

DESCRIPTION

Watched state got reset in mylist in anidb after re-importing files.

Reset state is 0/12 column.
image

Shoko still has correct watched states.
image
Auto update settings
image
AniDB Options
image

STEPS TO REPRODUCE

Move files out.
Run remove missing files.
Move files to drop folder/collection.
Run import.

@hidden4003

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2019

Same behavior was reported in 3.9.4 as well.

@Mik1ll

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

I think this should be high priority, I wiped out quite a few watched states on AniDB without realizing it. Any file with watched status in AniDB is marked unwatched when imported. New Shoko users will ruin their AniDB MyLists if they have their files already added. Reproducible.

@da3dsoul

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

I agree that it should be high priority. It's just not easy to track down and fix. The MyList code is a mess.

@Pizz001

This comment has been minimized.

Copy link

commented Mar 8, 2019

cheers for passing this info on, but due to my file sizes this may almost be impossible for me to fix, as I have 16tbs of anime to try and move about, it may work if i rename folders but that will screw my network shares up ..but then again redoing shares could be an easier way, i need to have a think about the best way

question, if i blank a new but empty folder, then rename my full folders to "name1" then tell it to look at the new empty "name" folder, that should see it as blank ...yeah there should be aby hidden files or anything I need to be on the lookout for

then run the remove missing files

once done then rename the folder and delete the empty one

before the reimport

@da3dsoul

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

What ? Sorry that English is not doing it for me. The way to avoid this is not running remove missing files.

@hidden4003

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

It only happens if you replace release for example, but just rearranging files run import should fix paths and this issue should not trigger.

@Pizz001

This comment has been minimized.

Copy link

commented Mar 9, 2019

What ? Sorry that English is not doing it for me. The way to avoid this is not running remove missing files.

sorry that's the meds I'm on turns my mind into a goldfish and as it's for 3 discs in my neck replaced twice that control my whole right side inc my hand, even I'll say it can come out a bit odd .. it's ok too lol, i take no offence as that's classed as good to somethings i've typed :)

@Pizz001

This comment has been minimized.

Copy link

commented Mar 9, 2019

It only happens if you replace release for example, but just rearranging files run import should fix paths and this issue should not trigger.

I'll try that if I can make space somehow

@Pizz001

This comment has been minimized.

Copy link

commented Mar 9, 2019

anidb found that my problem started on 03/03/2019 , i managed to hope on to discord and give Mik1ll my log for that day as a zipped file

@Mik1ll

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

else if (ServerSettings.AniDB_MyList_SetUnwatched && !watchedLocally)

Importing files goes here and imported files watchedLocally bool is always false because originalWatchedDate is null. It seem sto me that lines 128 to 147 shouldn't be used for files being added, as the Set Watched (ServerSettings.AniDB_MyList_SetWatched) and Set Unwatched (ServerSettings.AniDB_MyList_SetWatched) are described as manual actions (unless you choose to set watched state on files through the Video player options).

Mik1ll added a commit to Mik1ll/ShokoServer that referenced this issue May 28, 2019

Fix ShokoAnime#770;
Ensure force add file to MyList overwrites AniDB data

@da3dsoul da3dsoul closed this in 6d990eb May 28, 2019

da3dsoul added a commit that referenced this issue May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.