Add series and movies grouping and refactor internals #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revam
force-pushed
the
add-grouping-and-refactor
branch
2 times, most recently
from
1e075ba
to
62b851c
Compare
revam
force-pushed
the
add-grouping-and-refactor
branch
from
62b851c
to
0f075ee
Compare
revam
changed the title
revam
force-pushed
the
add-grouping-and-refactor
branch
2 times, most recently
from
45bcbcf
to
0bfcd7f
Compare
revam
force-pushed
the
add-grouping-and-refactor
branch
2 times, most recently
from
cb143ac
to
72f7aee
Compare
revam
force-pushed
the
add-grouping-and-refactor
branch
from
7e63627
to
afd3e3f
Compare
## Changes - Refactored Helper.cs into three new seperate classes, under a new namespace `Shokofin.Utils`. Streamlined how to get data from the api, by going through new helpers instead of directly using the api _everytime_. - `Shokofin.Utils.DataUtil` - holds helpers for getting data - `Shokofin.Utils.OrderingUtil` - holds helpers for ordering episodes - `Shokofin.Utils.TextUtil` - holds helpers related to text - Updated the configuration page layout - Added Series grouping based on Shoko's group feature - Seasons in the grouped series can be ordered by release-date or in chonological order. ## To-do - Depends on missing feature: relations in group
# Changes - Commented out reference to Chronological ordering in the html config template - Removed the api call for group relations (that currently does not exist in Shoko master branch) - Removed the incomplete chronological sorter - Made the "default" (AKA let shoko decide) ordering the default
the leading url to the shoko server (e.g. so proxies are supported)
Don't append the ": " if the episode title is empty in the current language for movies
(i.e. anidb, tvdb)
grouped. A workaround, for now.
Add a warning for series grouping using shoko's groups, change "Default" to "Let Shoko decide", and correct "libraries" to "library types"
Don't return id from *ByPath endoints, renamed and/or moved some classes added in this PR, etc. See the commit for all changes.
So, did some coding over the weekend; - added a library "scanner", and removed all the other ignore rules present - laid the ground work for adding virtual missing episodes, theme videos, trailers, interviews to series/seasons (will be added in a later commit) - fixed the code style for _most_ of the code base to _my liking_. - fixed the "bug" resulting in single "episodes" of series with type "movie" only being named "Complete Movie" (note; it was not really a bug, but working as intended) - _a lot_ of refactor of the api manager.
revam
force-pushed
the
add-grouping-and-refactor
branch
from
afd3e3f
to
79d62d8
Compare
revam
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a Library "Scanner" to "pre-heat" the entries we need to fetch from Shoko and to filter out some items.
Add an Api Manager (basically a data store for the items retrived from shoko). Streamlining how to get data from the API, by going through the manager instead of directly using the API (everytime).
Refactored Helper.cs into two new separate classes, under a new namespace
Shokofin.Utils.Shokofin.Utils.Ordering- holds helpers for ordering and sorting groups/series/seasons/episodes.Shokofin.Utils.Text- holds helpers related to text manipulation and extraction (e.g. sanitize the summary, get the title of a series/season/episode, etc.)Updated the configuration page
Episodes of type
Credits,ThemeSongandTrailerare excluded, because they will be added to series separately (read: not as episodes) in a later PRAdded Series grouping based on Shoko's group feature
Normal and special episodes are grouped together within the same season, for now. With the specials having an negative index. (This is a temporary state, and will be fixed later)
Seasons in the grouped series can be ordered by Shoko release-date (or in chronological order when that's added).
Added Movies grouping based on Shoko's group feature
Added an experimental library separation feature, so you can use the same library on disk, but have separate movie and series libraries in Jellyfin. Though, keep in mind this feature is experimental, and requires a workaround to work where you either have to mount the same directory twice in docker or use a symbolic link for one of them