Make graph.add_edge run in O(1) instead of O(degree(V)) #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now graph.add_edge runs in O(degree(V)) because
node_neighbors
is a list andv not in self.node_neighbors[u]
runs in O(len(self.node_neighbors)). This leads to O(EV) creation time for dense graphs. Another worst case is a star — a graph where a single vertex is connected to each of other vertices, which will be constructed in O(V^2) having just O(V) edges & vertices.This pull request fixes
v not in self.node_neighbors[u]
running time by makingnode_neighbors
aset
, which guarantees O(1)__contains__
check.neighbors
still cast it tolist
for immutability & backward compatibility.