Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Kruskal's Minimimum Spanning Tree construction algorithm #3

Merged
merged 2 commits into from Apr 29, 2018

Conversation

goldragoon
Copy link

@goldragoon goldragoon commented Apr 18, 2018

Since that, in sparse graph kruskal's algorithm works better in general.
But this beloved package dont't have krulskal's algorithm implementation.
So I add kruskal's algorithm using disjoint set datastructure class(UnionFind) to find minimum edge without cycle.

If any suggestion to improve my code, please note it.

Implement kruskal's minimum spanning tree algorithm for sparse graph.
@goldragoon goldragoon changed the title Implementation of Kruskal mImplementation of Kruskal's Minimimum Spanning Tree construction algorithm Apr 18, 2018
@coveralls
Copy link

coveralls commented Apr 18, 2018

Pull Request Test Coverage Report for Build 21

  • 50 of 52 (96.15%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 93.732%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/pygraph/algorithms/minmax.py 28 29 96.55%
core/pygraph/classes/unionfind.py 21 22 95.45%
Files with Coverage Reduction New Missed Lines %
core/pygraph/algorithms/minmax.py 3 95.76%
Totals Coverage Status
Change from base Build 17: -0.2%
Covered Lines: 1271
Relevant Lines: 1356

💛 - Coveralls

@goldragoon goldragoon changed the title mImplementation of Kruskal's Minimimum Spanning Tree construction algorithm Implementation of Kruskal's Minimimum Spanning Tree construction algorithm Apr 18, 2018
@agroszer
Copy link
Member

thank you,

but please fix travis py 3.x tests and add tests for your added code to keep coverage at least level

@goldragoon
Copy link
Author

@coveralls
Thanks for replying.
I will fix it asap.

Add test code for splited minimum spanning tree construction algorithms
@agroszer agroszer merged commit aaace7e into Shoobx:master Apr 29, 2018
@agroszer
Copy link
Member

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants