Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

Edit Address and Add Address links have stopped working #471

Closed
suture opened this issue Oct 1, 2015 · 9 comments
Closed

Edit Address and Add Address links have stopped working #471

suture opened this issue Oct 1, 2015 · 9 comments

Comments

@suture
Copy link

suture commented Oct 1, 2015

Edit Address and Add Address links have stopped working.

They're also no longer working in the demo store
re: http://timber-demo.myshopify.com/account/addresses#

The error below is from the demo store.

Something has changed as they did work before.
I'm using Safari Version 8.0.8 (10600.8.9) on a 27" iMac

[Error] TypeError: undefined is not a function (evaluating 'Shopify.each(i,function(t){var e=document.createElement("option");e.value=t[0],e.innerHTML=t[1],o.appendChild(e)})')
countryHandler (shopify_common-e876869f8c5d2d084d8a32ebbc12aeab.js, line 1)
initCountry (shopify_common-e876869f8c5d2d084d8a32ebbc12aeab.js, line 1)
CountryProvinceSelector (shopify_common-e876869f8c5d2d084d8a32ebbc12aeab.js, line 1)
global code (addresses, line 734)
[Error] TypeError: undefined is not an object (evaluating 'Shopify.CustomerAddress.toggleNewForm')
onclick (addresses, line 397)

@cshold
Copy link
Contributor

cshold commented Oct 1, 2015

@christianblais could your changes to shopify_common.js have effected this?

@suture
Copy link
Author

suture commented Oct 1, 2015

It's working in Supply, React and Solo.

But also broken in Classic, Brooklyn, Minimal and Timber

@cshold
Copy link
Contributor

cshold commented Oct 1, 2015

A fix is in for shopify_common.js to be more efficient but also backwards compatible.

@christianblais
Copy link

Deploying the fix right now.

@christianblais
Copy link

Deployed. Can we confirm it works? Works on my shop, but that's only one theme.

@cshold
Copy link
Contributor

cshold commented Oct 1, 2015

Yup, fixed on my end too. Thanks for being so quck

@sinak
Copy link

sinak commented Oct 4, 2015

Thanks for fixing this so quickly!

@Cam
Copy link

Cam commented Aug 9, 2016

I'm seeing this issue on a new Timber based theme.

@cshold
Copy link
Contributor

cshold commented Aug 9, 2016

Just tested on master with no issues. Can you show any error messages you got @Cam ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants