This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Normalize #153
Merged
Normalize #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iant... Also, customers who have only 1 variant may still want to show the variant title if it's not set to 'Default Title' so I am removing the condition altogether rather than fixing it.
…st 1 variant..." This reverts commit 3c68c5a.
| @@ -733,10 +755,7 @@ h1, h2, h3, h4, h5, h6, | |||
| h1 a, h2 a, h3 a, h4 a, h5 a, h6 a, | |||
| .h1 a, .h2 a, .h3 a, .h4 a, .h5 a, .h6 a { font-weight: inherit; } | |||
There was a problem hiding this comment.
@mpiotrowicz Should I just extend h1 from .h1 (and so on), rather than duplicate up the selectors here and below?
There was a problem hiding this comment.
hmm, I'd probably go as follows:
h1,h2,h3,h4,h5,h6 {
a {
font-weight: inherit;
}
}
and then have all the typography helpers extend the tags, so
.h1 {
@extend h1;
}
That would include the link inside .h1 as well
There was a problem hiding this comment.
Am I the devil if I keep those extends on one line?
.h1 { @extend h1; }
.h2 { @extend h2; }
.h3 { @extend h3; }
.h4 { @extend h4; }
.h5 { @extend h5; }
.h6 { @extend h6; }
It goes against the styleguide, but it's so pretty.
There was a problem hiding this comment.
I'd stick with the guide for consistency. This style works but as soon as anything has to change, it would have to move to 2 lines anyway.
Add jQuery selectors to doc ready
Conflicts: assets/timber.scss.liquid
cshold
added a commit
that referenced
this pull request
Jul 29, 2014
Normalize CSS and Clean shop.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at normalizing the CSS, rather than resetting.
normalizecode in to the sections where the rest of the attribute is definedResolves #151