This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Moved product JS to external file (mostly) #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1083,7 +1081,6 @@ var ajaxifyShopify = (function(module, $) { | |||
| qty = parseInt( qtySelector.val().replace(/\D/g, '') ); | |||
|
|
|||
| var qty = validateQty(qty); | |||
| console.log('3: ' + qty); | |||
… to product template
| @@ -15,6 +15,17 @@ timber.cacheSelectors = function () { | |||
| } | |||
| }; | |||
|
|
|||
| timber.cacheProductSelectors = function() { | |||
There was a problem hiding this comment.
@mpiotrowicz Moved them to a new function. Now this function is called at the beginning of timber.productJS, which lets us move the initializing JS back to product.liquid.
|
looks good to me. much nicer!! |
cshold
added a commit
that referenced
this pull request
Sep 3, 2014
Moved product JS to external file (mostly)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
product.liquidJS intoshop.js.liquidshop.js.liquidcache'd selectors, the remaining JS is moved totheme.liquidso it runs aftertimber.initis fired.Update:
timber.init(therefor can be moved back toproduct.liquid)cc/ @stevebosworth @mpiotrowicz