This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
BEM styles for ajax cart #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <input type="text" class="js--num" value="{{itemQty}}" min="1" data-id="{{id}}" aria-label="quantity" pattern="[0-9]*" name="{{inputName}}" id="{{inputId}}"> | ||
| <button type="button" class="js--qty-adjuster js--add" data-id="{{id}}" data-qty="{{itemAdd}}">+</button> | ||
| <button type="button" class="js-qty__adjust js-qty__adjust--minus" data-id="{{id}}" data-qty="{{itemMinus}}">−</button> | ||
| <input type="text" class="js-qty__num" value="{{itemQty}}" min="1" data-id="{{id}}" aria-label="quantity" pattern="[0-9]*" name="{{inputName}}" id="{{inputId}}"> |
There was a problem hiding this comment.
nitpicking but maybe js-qty__qty-num for consistency with ajaxcart__qty-num? It's a weird name but maybe makes a bit more sense?
There was a problem hiding this comment.
Doesn't that seem redundant? I'm thinking js-qty__num and js-qty__adjust are obvious enough what they do, within their context.
There was a problem hiding this comment.
ya, was more thinking for readability in a stylesheet. js-qty__qty-num is maybe more explicit that it is is linked/similar in function to ajaxcart__qty-num?
I think that either case has pros and cons so probably just go with yours.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving old, disorganized ajax cart selectors over to BEM.
cc/ @stevebosworth @Shopify/fed