This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
New empty states #272
Merged
New empty states #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So onboarding text will always be in English, not translatable? |
|
For what it's worth, we had our themes turned down for not having translatable onboarding text. |
|
Ah good to know. My thoughts were this is more of admin text, not storefront. It does make sense for everything to be translatable though. I'll fix that up. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some nicer empty states for Timber. Based on global assets. Downside is, if these assets are ever moved countless themes could be affected. Thoughts?
Live demo
@stevebosworth @fredryk @carolineschnapp @mpiotrowicz