This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Force select option text color for IE #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshold
added a commit
that referenced
this pull request
Nov 21, 2014
Force select option text color for IE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small but necessary addition. IE10 dropdowns have a fixed white background color. This forces the text to always be visible, rather than inherit the select's text color. This is evident in dark themes that use white as the
selecttext color. This only affects IE'soptionelements, as nearly every other browser has a preset style that you can't override.Only downside is that IE9 will also change the current value's text color, so we need to force the background color too. IE9 screenshot is below. I think it's an acceptable flaw to this.
cc/ @Shopify/fed