Icon Font Update #284
Icon Font Update #284
Conversation
| @@ -104,6 +104,9 @@ | |||
| - Documentation: http://shopify.com/timber#ajax-cart | |||
| {% endcomment %} | |||
| <a href="/cart" id="CartToggle"> | |||
| <span class="icon-fallback-text"> | |||
There was a problem hiding this comment.
there's no copy in this fallback text, is it needed? Fallback should be there if an icon isn't accompanied by any visible text or if the text isn't representative of what the icon shows. eg. if the icon wasn't there, would something still be actionable and would users know what it did? cc @stevebosworth
There was a problem hiding this comment.
This is a superfluous icon, really. There already is text beside it, so if it loads, great, if not, not a problem.
There was a problem hiding this comment.
ah ok, with the comment below as well i see how this is organized. If there's no fallback text required, just wondering if it needs to be wrapped in that element at all? I can open a separate issue elsewhere
There was a problem hiding this comment.
Ah I see what you mean. Yea, if there is no fallback the wrapper can be
removed. The default .icon:before is hidden unless icon fonts are
supported. Please open a new issue and I can revisit this.
On Wed, Dec 3, 2014 at 9:41 AM, Monika Piotrowicz notifications@github.com
wrote:
In layout/theme.liquid:
@@ -104,6 +104,9 @@
- Documentation: http://shopify.com/timber#ajax-cart
{% endcomment %}
<span class="icon-fallback-text">ah ok, with the comment below as well i see how this is organized. If
there's no fallback text required, just wondering if it needs to be wrapped
in that element at all? I can open a separate issue elsewhere—
Reply to this email directly or view it on GitHub
https://github.com/Shopify/Timber/pull/284/files#r21234684.
Carson Shold
Front End Web Developer
| <button type="button" title="Grid view" class="change-view{% unless template contains 'list' %} change-view--active{% endunless %}" data-view="grid"> | ||
| <span class="icon-fallback-text"> | ||
| <span class="icon icon-grid-view" aria-hidden="true"></span> | ||
| <span class="fallback-text">Grid View</span> |
There was a problem hiding this comment.
@jonasll Could I get a translation for "Grid View" and "List View" please.
frptpt-BRdees |
Updated icon fonts to include. Docs to be updated after this PR is merged.
Also moved the inline collection view JS into
shop.js.This lets us delete the inline svg icons previously used for collection views, while adding a few more commonly used icons to the set.
Edit: also moved collections and blog sidebars below main content with
grid--revon mobile sizes. Should be its own PR, but minor enough I tacked it on here.@mpiotrowicz @stevebosworth