This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Ajaxify image #304
Merged
Ajaxify image #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o afshing-ajaxify-image
Closed
cshold
added a commit
that referenced
this pull request
Dec 23, 2014
Ajaxi cart fix for when products have no image
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: There is an issue in the ajaxify.js, when the default cart is used (useCartTemplate = false).
If the product that is added to the cart has no image, the ajaxify shopping cart doesn't open.
Reason: There is a hack in this code that create the thumbnail of the image by adding "_small" at the end of the file name. However, /cart.js will return null for products with no image.
Good Solution: Change the Shopify API to return the "no-image" thumbnail instead of null when there is no image assigned to the product
Hack Solution: hard-coding the url of the default no-image thumbnail. I just used the one that I got from my shop. It doesn't look to be the generic one, and also it is medium according to the url.
Edit: I added some minor syntax fixes in the last commit. All the rest was done by @afshing