This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Update cart properties size check #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -989,7 +989,7 @@ hr { | |||
| } | |||
| } | |||
|
|
|||
| .rte-header { | |||
| .rte--header { | |||
| margin-bottom: 0; | |||
There was a problem hiding this comment.
This should probably be .rte__header since it's not really a modifier?
There was a problem hiding this comment.
Didn't mean to include this here, but you're right. I'll update
|
Looks good 👍 |
|
Awaiting word whether the liquid will be fixed to make fix this unnecessary. |
|
Rather than remove the check, I've now assigned a new variable using the |
cshold
changed the title
|
Cool, good to know about using the size property. 🚢 |
cshold
added a commit
that referenced
this pull request
Jan 19, 2015
Update cart properties size check
rickydazla
added a commit
to rickydazla/Tricky3eme
that referenced
this pull request
Jan 21, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this Shopify forum post,
{% if item.properties.size > 0 %}will never run so here it is removed. Theforloop is more than capable of handling this on its own.Fixes #317
cc @stevebosworth