This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Default blankstates #319
Merged
Default blankstates #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% assign emptyState = true %} | ||
| {% endunless %} | ||
|
|
||
| {% include 'onboarding-empty-collection' %} |
There was a problem hiding this comment.
This is only used once, so don't think it needs to be put in a snippet. That folder is getting pretty large as it is.
Same goes for the other new snippets. Thoughts?
There was a problem hiding this comment.
I'm a sucker for separate files and includes. Much easier to read imho. Easier to remove or turn on and off too.
|
Finally got around to testing this out. All looks great with the exception of the |
cshold
added a commit
that referenced
this pull request
Jan 22, 2015
Default blankstates for collections page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cshold @mpiotrowicz
Adds some default blank state products and collections to help with onboarding when the theme is first installed in a blank shop.