This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Update to proper default product variant price #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Set a class for sold-out and on-sale items | ||
| {% endcomment %} | ||
| <div class="grid__item {{grid_item_width}}{% if sold_out %} sold-out{% endif %}{% if on_sale %} on-sale{% endif %}"> | ||
| <div class="grid__item {{grid_item_width}}"> |
There was a problem hiding this comment.
Coding style question: we do not include spaces in a Liquid output tag when no filters are applied intentionally?
There was a problem hiding this comment.
Should definitely have spaces. I'll fix it up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@carolineschnapp Saw you mention this issue in our of our themes, so making the fix here as well. Set the default liquid price to that of the selected variant when set.
Using
current_variantto holdproduct.selected_or_first_available_variantfor brevity.cc/ @stevebosworth @mpiotrowicz @fredryk