Add i18n for catch-all collection tags #375
Conversation
| @@ -74,6 +74,7 @@ | |||
| }, | |||
| "collections": { | |||
| "general": { | |||
| "all_of_collection": "Tous les {{ collection }}", | |||
There was a problem hiding this comment.
We actually got rid of this in our Shopify themes. There are 3 issues with passing the collection title:
- Grammatical. This will work half the time in French for example, because words have gender there ( same in Spanish ! ).
Tous lesonly works with masculine words. - You often end up having a collection which name is 'All Products'. Then you have 'All all products'.
- To override the automatic /collections/all collection, merchants need to create a collection with handle
alland when they do that, they often create a collection which title isAll( to end up with the right handle ) and then you will seeAll all.
On paper this seems like the best idea though! It's just too bad we cannot really make it work. :'(
There was a problem hiding this comment.
Ah good to know. Any reason to leave just All there, or strip that out too?
There was a problem hiding this comment.
For French it's definitely a show-stopper, so you can safely not reference the passed collection. 50% of times the sentence will read very bad, not just a little bad. So, in French translation use:
"all_of_collection": "Tout",
That is like All. It is not weird, it just works all the time. Just using this:
"all_of_collection": "{{ collection }}",
... will be confusing imho. How do you un-filter? How do you see all products? What is a sub-category and what is the main category / collection?
There was a problem hiding this comment.
Good call. I'll go with All for French and Spanish and leave the others intact. Sound good?
There was a problem hiding this comment.
Yes! Sounds great!
On Fri, Mar 20, 2015 at 1:32 PM, Carson Shold notifications@github.com
wrote:
In locales/fr.json
#375 (comment):@@ -74,6 +74,7 @@
},
"collections": {
"general": {
"all_of_collection": "Tous les {{ collection }}",Good call. I'll go with All for French and Spanish and leave the others
intact. Sound good?—
Reply to this email directly or view it on GitHub
https://github.com/Shopify/Timber/pull/375/files#r26858962.
|
🚢 🚢 🚢 |
Add i18n for catch-all collection tags
Catch-all links to create _All _collection** links were not i18n friendly. This fixes that.
cc @carolineschnapp