This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Fix broken edit/delete buttons on address template with pagination #386
+80
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created a PR where I wrap everything in the paginate tags, rather than duplicating that for the JS. Seems to work well. Any issues with it you can see? |
|
👍 tested it and its perfect :) |
cshold
added a commit
that referenced
this pull request
Mar 31, 2015
Fix broken edit/delete buttons on address template with pagination
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #385
Instead of using multiple
paginatetags as the issue suggests (which also works), this wraps the entire template in the paginate tags to solve the same issue.cc @stevebosworth @schaeken