[Timber] update a11y prices #564
Conversation
| @@ -243,8 +245,11 @@ timber.productPage = function (options) { | |||
| $comparePrice | |||
| .html({{ 'products.product.compare_at' | t | json }} + ' ' + Shopify.formatMoney(variant.compare_at_price, moneyFormat)) | |||
| .show(); | |||
| $comparePriceA11y.attr('aria-hidden', 'false'); | |||
| $priceA11y.attr('aria-hidden', 'false'); | |||
There was a problem hiding this comment.
Does $priceA11y never get turned back to aria-hidden="true"?
There was a problem hiding this comment.
My understanding is that $priceA11y should never be set to aria-hidden="true" as it should always be 'visible' to the screen reader/VO, is that correct?
Setting aria-hidden to false may not be needed though, would not setting any value to the aria-hidden attribute have the same effect as setting it to false here?
There was a problem hiding this comment.
If it's never aria-hidden=true you don't have to set the attribute at all. Unset is the same as "false"
There was a problem hiding this comment.
If it's never aria-hidden=true you don't have to set the attribute at all. Unset is the same as "false"
Agreed. I missed that out.
|
@cshold @ruairiphackett did another fix in this commit: 124079d Updated demo: link |
|
Can you update that link, it's not Timber anymore |
|
The changes look good @matcaissy 馃憤 I don't think the changes are present on the updated demo link, but I tested them on my own test store and they look good 馃帺 |
|
Sorry folks, here's the demo: link |
|
Looks good, just wondering about one thing, there's 2 labels on the compare at price on the product page when it is present:
|
|
Closing down, will revisit themes a11y in a new project (Q2?) |
Fix for https://github.com/Shopify/shopify-themes/issues/3523
Did some cleanup - and organized better the a11y prices for screenreaders on the product grid, product and search page.
Demo: link
@ruairiphackett 馃憖
cc @cshold