Freeze constants and hash in services #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [ 'Expedited Shipping', 'Expedited' ], | ||
| [ 'Priority Shipping', 'Priority' ] | ||
| ].inject({}){|h, (k,v)| h[k] = v; h} | ||
| SHIPPING_METHODS | ||
| end |
There was a problem hiding this comment.
@garethson do we use this method? Thoughts on putting a note in the change log and making this a bigger version bump to just use the constant?
There was a problem hiding this comment.
@kevinhughes27 We do use this method, and a couple of the providers actually do run code to generate it. So maybe leave that change for later.
There was a problem hiding this comment.
okay, definitely leave the method then!
leaexplores
force-pushed
the
FreezeConstants
branch
from
bf07bd6
to
f3a22da
Compare
|
Alright, I inlined freezed the 2 xml / json constants. Let me know if there's more to inline. Thanks! |
leaexplores
force-pushed
the
FreezeConstants
branch
from
f3a22da
to
205687d
Compare
garethson
added a commit
that referenced
this pull request
Jan 5, 2016
Freeze constants and hash in services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR freezes constants located in the services implementations.
It should help a tad perf wise and avoid mutation errors.
Extracted from PR #68