SagePay: Fixed special handling for Japanese Yen currency to not send…

… fractional amounts * This is a followup commit to: b4d852e
Shopify · Sep 14, 2010 · b7e8c35 · b7e8c35
1 parent 1e650c6
commit b7e8c35
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,9 +1,11 @@
 = ActiveMerchant CHANGELOG
 
+* Fix SagePay special handling for Japanese YEN currency to not send fractional amounts [Soleone]
+
 == Version 1.7.2 (August 27, 2010)
 
 * Update Braintree integration to play nicely with the braintree 2.5.0 gem [Soleone]
-* Fix SagePay to not send fractional amounts for Chinese YEN currency [Soleone]
+* Fix SagePay to not send fractional amounts for Japanese YEN currency [Soleone]
 
 == Version 1.7.1 (July 28, 2010)
 

diff --git a/lib/active_merchant/billing/gateways/sage_pay.rb b/lib/active_merchant/billing/gateways/sage_pay.rb
@@ -32,7 +32,7 @@ class SagePayGateway < Gateway
         :jcb => "JCB"
       }
 
-      CURRENCIES_WITHOUT_FRACTIONS = [ 'YEN' ]
+      CURRENCIES_WITHOUT_FRACTIONS = [ 'JPY' ]
 
       ELECTRON = /^(424519|42496[23]|450875|48440[6-8]|4844[1-5][1-5]|4917[3-5][0-9]|491880)\d{10}(\d{3})?$/
 

diff --git a/test/unit/gateways/sage_pay_test.rb b/test/unit/gateways/sage_pay_test.rb
@@ -107,10 +107,10 @@ def test_cvv_result
 
   def test_dont_send_fractional_amount_for_chinese_yen
     @amount = 100_00  # 100 YEN
-    @options[:currency] = 'YEN'
+    @options[:currency] = 'JPY'
 
     @gateway.expects(:add_pair).with({}, :Amount, '100', :required => true)
-    @gateway.expects(:add_pair).with({}, :Currency, 'YEN', :required => true)
+    @gateway.expects(:add_pair).with({}, :Currency, 'JPY', :required => true)
 
     @gateway.send(:add_amount, {}, @amount, @options)
   end