Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use list markup for cart line items #720

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Use list markup for cart line items #720

merged 1 commit into from
Sep 10, 2020

Conversation

spencercanner
Copy link
Contributor

@spencercanner spencercanner commented Sep 8, 2020

  • Wrap cart line item list in a <ul />
  • Wrap each line item in a <li />
  • Add a list role to the <ul/ > to address a Safari VoiceOver bug
    • I didn't opt for the solution posted in MDN since it's more of a hack rather than a permanent solution. This was adding whitespace above the line item product title

To 🎩

  • Navigate a virtual cursor to a cart with line items
  • Verify that the screen reader announces the line items as a list

Browsers:

  • Safari - Mac - VoiceOver
  • Firefox - Windows - NVDA
  • Sanity check that cart doesn't look visually different

Browsers:

  • Chrome - Mac
  • Safari - Mac
  • Firefox - Mac
  • Edge - Mac
  • Legacy Edge - Windows
  • Edge - Windows
  • Chrome - Windows
  • Firefox - Windows
  • Safari - iOS
  • Chrome - Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants