[Shopify/payments-platform#4234] Prototype for Shopify CLI Payment Apps Support #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
bazay
force-pushed
the
payments-apps-prototype
branch
from
59f3636
to
7a543ce
Compare
Coverage report
Show new covered files 🐣
Test suite run success1495 tests passing in 670 suites. Report generated by 🧪jest coverage report action from ee8f2a4 |
isaacroldan
reviewed
Nov 6, 2023
| import {BaseSchema} from '../schemas.js' | ||
| import {zod} from '@shopify/cli-kit/node/schema' | ||
|
|
||
| const PaymentsAppSchema = BaseSchema.extend({ |
There was a problem hiding this comment.
is the schema the same for all payment extensions? can we reuse one then?
There was a problem hiding this comment.
Still investigating this, however if the answer is yes then re-using the same specification makes sense to me 👍
bazay
force-pushed
the
payments-apps-prototype
branch
3 times, most recently
from
700d1e0
to
8e4705f
Compare
bazay
force-pushed
the
payments-apps-prototype
branch
from
8e4705f
to
ee8f2a4
Compare
|
@bazay Can we close this PR if it's no longer relevant? thanks! |
|
Closing as prototype phase complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
https://github.com/Shopify/payments-platform/issues/4234
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.