Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build flow template extensions during deploy #3884

Merged
merged 1 commit into from
May 10, 2024

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

  • Flow templates introduced a new build step to include localization files in the bundled zip file.
  • This build step is only meant for deploy and it currently fails during dev

WHAT is this pull request doing?

  • Don't build flow template extensions if env is development
  • Even if we build, check that we are not building in the wrong path.

How to test your changes?

  • Create a flow template extension
  • Try to dev, it should work (crashes on main)

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.89% (-0.02% 🔻)
6965/9689
🟡 Branches
68.7% (-0.06% 🔻)
3429/4991
🟡 Functions 71.3% 1861/2610
🟡 Lines
73.2% (-0.01% 🔻)
6564/8967
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / extension-instance.ts
84.8%
77.32% (-0.58% 🔻)
90.48% 86.21%
🟡
... / bundle.ts
75.81% (-1.24% 🔻)
64.52% (-4.45% 🔻)
66.67% 76.67%
🟢
... / ConcurrentOutput.tsx
97.62% (-2.38% 🔻)
75% (-8.33% 🔻)
100%
97.44% (-2.56% 🔻)

Test suite run success

1641 tests passing in 763 suites.

Report generated by 🧪jest coverage report action from 4299ad2

@isaacroldan isaacroldan added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 4aa2c0b May 10, 2024
@isaacroldan isaacroldan deleted the fix-flow-templates-dev-crash branch May 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants