Merge pull request #3884 from Shopify/fix-flow-templates-dev-crash

Only build flow template extensions during deploy
Shopify · May 10, 2024 · 4aa2c0b · 4aa2c0b
2 parents 2787780 + 4299ad2
commit 4aa2c0b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/packages/app/src/cli/models/extensions/extension-instance.ts b/packages/app/src/cli/models/extensions/extension-instance.ts
@@ -279,7 +279,7 @@ export class ExtensionInstance<TConfiguration extends BaseConfigType = BaseConfi
       return buildFunctionExtension(this, options)
     } else if (this.features.includes('esbuild')) {
       return buildUIExtension(this, options)
-    } else if (this.specification.identifier === 'flow_template') {
+    } else if (this.specification.identifier === 'flow_template' && options.environment === 'production') {
       return buildFlowTemplateExtension(this, options)
     }
 

diff --git a/packages/app/src/cli/services/build/extension.ts b/packages/app/src/cli/services/build/extension.ts
@@ -72,7 +72,7 @@ export async function buildFlowTemplateExtension(
   options: ExtensionBuildOptions,
 ): Promise<void> {
   options.stdout.write(`Building Flow Template extension ${extension.localIdentifier}...`)
-  await bundleFlowTemplateExtension(extension, options)
+  await bundleFlowTemplateExtension(extension)
   options.stdout.write(`${extension.localIdentifier} successfully built`)
 }
 

diff --git a/packages/app/src/cli/services/extensions/bundle.ts b/packages/app/src/cli/services/extensions/bundle.ts
@@ -90,17 +90,14 @@ export async function bundleThemeExtension(
   )
 }
 
-export async function bundleFlowTemplateExtension(
-  extension: ExtensionInstance,
-  options: ExtensionBuildOptions,
-): Promise<void> {
-  options.stdout.write(`Bundling Flow Template extension ${extension.localIdentifier}...`)
+export async function bundleFlowTemplateExtension(extension: ExtensionInstance): Promise<void> {
   const files = await flowTemplateExtensionFiles(extension)
 
   await Promise.all(
     files.map(function (filepath) {
       const relativePathName = relativePath(extension.directory, filepath)
       const outputFile = joinPath(extension.outputPath, relativePathName)
+      if (filepath === outputFile) return
       return copyFile(filepath, outputFile)
     }),
   )