Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

remove direct dependency on thin as the rack implementation #183

Closed
wants to merge 1 commit into from

Conversation

tempredirect
Copy link

the main reason for this is to allow compatibility with jruby as thin is not really compatible out of the box with jruby.

the change basically removes thin from the dashing.gemspec file and moves it to the dashboard's Gemfile where it is wrapped in a platform :ruby block and instead of using 'thin start' it uses 'rackup' to start the server.

initial problems:

  • current projects may revert back to webbrick on up grading as there Gemfile won't have been changed
  • the dashing stop command assumes 'thin' as there doesn't seem to be an equivalent rackup, guess may have to use the rack.pid file and kill the process

the main reason for this is to allow compatibility with jruby as thin
is not really compatible out of the box with jruby.
@davefp
Copy link
Contributor

davefp commented Aug 14, 2013

I like this. Giving users the ability to use the app server of their choice is a great addition.

Because of the breaking changes it'll have to be part of a 2.0.0 release though, so I may not merge it in for a while. It will also be dependent on fixing the dashing stop command.

@theigl
Copy link

theigl commented Aug 22, 2013

+1

3 similar comments
@ledesma
Copy link

ledesma commented Dec 10, 2013

+1

@ducky427
Copy link

+1

@padi
Copy link
Contributor

padi commented May 31, 2014

+1

@terraboops
Copy link
Contributor

This PR can be closed as it is superseded by #427 -- hopefully that one is merged soon.

@pushmatrix
Copy link
Member

Yeah, moving all discussion to #427 for now

@pushmatrix pushmatrix closed this Jun 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants