Declaratively update quick order list

Remove unnecessary null check
Shopify · Feb 28, 2024 · 7b50505 · 7b50505
1 parent b419047
commit 7b50505
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 13 deletions.
diff --git a/assets/product-info.js b/assets/product-info.js
@@ -97,6 +97,7 @@ if (!customElements.get('product-info')) {
           const newProduct = html.querySelector('product-info');
           this.swapProductUtility.viewTransition(this, newProduct);
           this.relatedProducts?.initializeRecommendations(newProduct.dataset.productId);
+          this.quickOrderList?.refresh();
         };
       }
 
@@ -358,7 +359,13 @@ if (!customElements.get('product-info')) {
       get relatedProducts() {
         const sectionId = this.dataset.originalSection || this.dataset.section;
         const relatedProductsSectionId = SectionId.getIdForSection(SectionId.parseId(sectionId), 'related-products');
-        return document.querySelector(`product-recommendations[data-section-id="${relatedProductsSectionId}"]`);
+        return document.querySelector(`product-recommendations[data-section-id^="${relatedProductsSectionId}"]`);
+      }
+
+      get quickOrderList() {
+        const sectionId = this.dataset.originalSection || this.dataset.section;
+        const quickOrderListSectionId = SectionId.getIdForSection(SectionId.parseId(sectionId), 'quick_order_list');
+        return document.querySelector(`quick-order-list[data-id^="${quickOrderListSectionId}"]`);
       }
     }
   );

diff --git a/assets/quick-add.js b/assets/quick-add.js
@@ -69,7 +69,7 @@ if (!customElements.get('quick-add-modal')) {
       }
 
       preventVariantURLSwitching(productElement) {
-        productElement.querySelector('product-info')?.setAttribute('data-update-url', 'false');
+        productElement.querySelector('product-info').setAttribute('data-update-url', 'false');
       }
 
       removeDOMElements(productElement) {

diff --git a/assets/quick-order-list.js b/assets/quick-order-list.js
@@ -79,7 +79,6 @@ class QuickOrderList extends HTMLElement {
   }
 
   cartUpdateUnsubscriber = undefined;
-  sectionRefreshUnsubscriber = undefined;
 
   onSubmit(event) {
     event.preventDefault();
@@ -94,21 +93,11 @@ class QuickOrderList extends HTMLElement {
       this.refresh();
     });
 
-    this.sectionRefreshUnsubscriber = subscribe(PUB_SUB_EVENTS.sectionRefreshed, (event) => {
-      const isParentSectionUpdated =
-        this.sectionId && (event.data?.sectionId ?? '') === `${this.sectionId.split('__')[0]}__main`;
-
-      if (isParentSectionUpdated) {
-        this.refresh();
-      }
-    });
-
     this.sectionId = this.dataset.id;
   }
 
   disconnectedCallback() {
     this.cartUpdateUnsubscriber?.();
-    this.sectionRefreshUnsubscriber?.();
   }
 
   onChange(event) {