Footer has extra empty space

[rozinashopify]

Describe the current behavior

When unchecking the "Show email signup" setting in the footer the space and lines around it stays in the footer.

Describe the expected behavior

This extra space and lines should not be there when the email sign up is turned off.

Version information (Dawn, browsers and operating systems)

• Dawn Version: 9.0.0
• Chrome Version 114.0.5735.90
• macOS Version 13.4

Possible solution

Additional context/screenshots

https://screenshot.click/31-18-8cc0e-9qmzb.png

[qui-gon-jon]

Hi @rozinashopify

It looks like the space is only appearing because both the "Enable Follow on Shop" and "Show social media icons" settings are checked, but neither are configured. The space is reserved for social media icons and the follow on shop button. If you disable both of those settings as well, then the extra space is removed: Screen recording

[rozinashopify]

I don't have any social media icons set in the theme, in this case the container shouldn't show up at all.

[qui-gon-jon]

I see your point and I agree. Right now if your social media icons are not set, you would also need to disable this checkbox in order to remove the white space.

But it would be more intuitive if we check for the "enable" setting, and also that there are social icons configured. I think we can solve this by editing this condition in sections/footer.liquid to add and has_social_icons == true

  {%- if section.blocks.size > 0
    or section.settings.newsletter_enable
    or section.settings.show_social and has_social_icons == true
    or section.settings.enable_follow_on_shop
  -%}