Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug that was causing extra spacing in footer #2745

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

lougoncharenko
Copy link
Contributor

@lougoncharenko lougoncharenko commented Jun 27, 2023

PR Summary:

Footer will not have extra space when unchecking the "Show email signup" setting in the footer.

Why are these changes introduced?

Fixes #2691 .

What approach did you take?

Added and has_social_icons == true in the section block to check if social media icons are present.

Other considerations

N/A

Visual impact on existing themes

If a merchant chooses to add an email sign up section and remove the default email sign up, there will no longer be a extra space between both section.

Testing steps/scenarios

  • Add email sign up section above the footer
  • uncheck "Show email signup" setting in the footer
  • add social media icons
  • uncheck language/ currency selector
  • add color schema

Demo links

Checklist

@lougoncharenko lougoncharenko linked an issue Jun 27, 2023 that may be closed by this pull request
@lougoncharenko lougoncharenko self-assigned this Jun 28, 2023
@lougoncharenko lougoncharenko requested review from kjellr and removed request for kjellr June 28, 2023 12:41
sections/footer.liquid Show resolved Hide resolved
@lougoncharenko lougoncharenko merged commit e3517e9 into main Jul 7, 2023
9 checks passed
@lougoncharenko lougoncharenko deleted the fix-footer-has-extra-empty-space-bug branch July 7, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer has extra empty space
3 participants