[Header locales] Support gradients #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recommend to not support gradient to align with the filter dropdown experience. Gradients don't blend well in a short height form. This is in favor of legibility/functionality. Thank you! |
eugenekasimov
previously approved these changes
Mar 13, 2023
metamoni
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Just noting some minor inconsistencies between the Language/currency selectors and the dropdown in the menu. The bottom borders seem to have a different colour, and the menu dropdown background is transparent, while the language/currency picker isn't. Do we want these to match?
borders.mp4
|
@metamoni ill take a look. If you share some screenshots of what you're seeing in those cases it would help 👌 |
metamoni
approved these changes
Mar 14, 2023
eugenekasimov
approved these changes
Mar 14, 2023
melissaperreault
approved these changes
Mar 14, 2023
damiankrzyz
added a commit
to damiankrzyz/dawn
that referenced
this pull request
Mar 14, 2023
[Header locales] Support gradients (Shopify#2386)
pangloss
added a commit
to pangloss/dawn
that referenced
this pull request
Mar 23, 2023
* shopify/main: Gift cards/add recipient (Shopify#2412) Update 1 translation file (Shopify#2453) [Slideshow] Add ambient movement to background (Shopify#2383) Wrap calls to search results ind collection counts in paginate to reduce additional requests (Shopify#2421) [Header] Add app block in the header section (Shopify#2238) [Image with Text] Add ambient movement to image (Shopify#2385) Update 1 translation file (Shopify#2450) [Blog post section] Fix slides size on mobile (Shopify#2368) Duplicated scrollbar in drawer menu (Shopify#2400) [Header locales] Support gradients (Shopify#2386) [Image banner] Add ambient movement to background (Shopify#2342)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR is adding gradient support to the country/region selector and language selector, in the header specifically.
Why are these changes introduced?
Fixes #2384
What approach did you take?
Added the
.gradientclass where necessary and set the background totransparenton thelocalization-form__select.Other considerations
Decision log
Visual impact on existing themes
No impact as the feature it's touching hasn't been released yet.
Testing steps/scenarios
Demo links
Checklist