Duplicated scrollbar in drawer menu #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoboludo
reviewed
Mar 14, 2023
assets/component-menu-drawer.css
Outdated
| @@ -93,7 +93,6 @@ details[open].menu-opening > .menu-drawer__submenu { | |||
| display: grid; | |||
| grid-template-rows: 1fr auto; | |||
| align-content: space-between; | |||
| overflow-y: auto; | |||
There was a problem hiding this comment.
That works. There is another option we could choose which is applying an overflow auto on the menu nav specifically: video
eugenekasimov
force-pushed
the
fix-double-scrollbar-drawer
branch
from
83ab577
to
a7440a3
Compare
metamoni
approved these changes
Mar 15, 2023
stufreen
approved these changes
Mar 15, 2023
ludoboludo
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Works well. I wonder if we should apply the position: relative on .menu-drawer__localization instead since the issue seem to be the absolute positioning from the localization-form's h2.
This way the fix is more targeted 🤔
Ill approve anyway but just thought ^
pangloss
added a commit
to pangloss/dawn
that referenced
this pull request
Mar 23, 2023
* shopify/main: Gift cards/add recipient (Shopify#2412) Update 1 translation file (Shopify#2453) [Slideshow] Add ambient movement to background (Shopify#2383) Wrap calls to search results ind collection counts in paginate to reduce additional requests (Shopify#2421) [Header] Add app block in the header section (Shopify#2238) [Image with Text] Add ambient movement to image (Shopify#2385) Update 1 translation file (Shopify#2450) [Blog post section] Fix slides size on mobile (Shopify#2368) Duplicated scrollbar in drawer menu (Shopify#2400) [Header locales] Support gradients (Shopify#2386) [Image banner] Add ambient movement to background (Shopify#2342)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR is to fix duplicated scrollbar in drawer menu.
Why are these changes introduced?
Fixes #2398 .
What approach did you take?
I see there might be different approaches to fix the issue, however the most simple one for me is to add
position: relativeto.menu-drawer__navigation-container. I couldn't find a case it would affect anything.Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Demo links
Checklist