Added add to cart behavior global setting #744
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Zobrazuje se v případě, že jsou povoleny návrhy produktů." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Košík", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Typ košíku", | ||
| "go_to_cart": { | ||
| "label": "Stránka" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Oznámení ve vyskakovacím okně" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Synlig når produktforslag aktiveret." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Indkøbskurv", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Indkøbskurvtype", | ||
| "go_to_cart": { | ||
| "label": "Side" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Pop op-meddelelse" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Sichtbar, wenn Produktvorschläge aktiviert sind." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Warenkorb", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Warenkorbstil", | ||
| "go_to_cart": { | ||
| "label": "Seite" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Pop-up-Benachrichtigung" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| } | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Cart", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Cart type", | ||
| "go_to_cart": { | ||
| "label": "Page" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Popup notification" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Visible cuando las sugerencias de productos están activadas." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Carrito", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Tipo de carrito", | ||
| "go_to_cart": { | ||
| "label": "Página" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Notificación emergente" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Näkyy, kun tuote-ehdotukset ovat käytössä." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Ostoskori", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Ostoskorin tyyppi", | ||
| "go_to_cart": { | ||
| "label": "Sivu" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Ponnahdusikkunailmoitukset" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Visible lorsque les suggestions de produits sont activées." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Panier", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Type de panier", | ||
| "go_to_cart": { | ||
| "label": "Page" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Notification pop-up" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Visibile quando i suggerimenti sui prodotti sono abilitati." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Carrello", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Tipo di carrello", | ||
| "go_to_cart": { | ||
| "label": "Pagina" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Notifica pop up" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "商品のおすすめが有効な場合に表示されます。" | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "カート", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "カートタイプ", | ||
| "go_to_cart": { | ||
| "label": "ページ" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "ポップアップ通知" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "제품 제안이 활성화되면 표시됩니다." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "카트", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "카트 유형", | ||
| "go_to_cart": { | ||
| "label": "페이지" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "팝업 알림" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Synlig når produktforslag er aktivert." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Handlekurv", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Handlekurvtype", | ||
| "go_to_cart": { | ||
| "label": "Side" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Popup-varsel" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Zichtbaar als productsuggesties zijn ingeschakeld." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Winkelwagen", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Type winkelwagen", | ||
| "go_to_cart": { | ||
| "label": "Pagina" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Pop-upmelding" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Widoczne w przypadku włączenia propozycji dotyczących produktu." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Koszyk", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Typ koszyka", | ||
| "go_to_cart": { | ||
| "label": "Strona" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Powiadomienie w wyskakującym okienku" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Visível quando as sugestões de produto estão habilitadas." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Carrinho", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Tipo de carrinho", | ||
| "go_to_cart": { | ||
| "label": "Página" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Notificação pop-up" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Visível quando as sugestões de produto estão ativas." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Carrinho", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Tipo de carrinho", | ||
| "go_to_cart": { | ||
| "label": "Página" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Notificação pop-up" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "Synlig när produktförslag är aktiverat." | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "Varukorg", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "Varukorgstyp", | ||
| "go_to_cart": { | ||
| "label": "Sida" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "Popup-avisering" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -209,6 +209,20 @@ | |
| "info": "จะปรากฏให้เห็นเมื่อเปิดใช้คำแนะนำสินค้า" | ||
| } | ||
| } | ||
| }, | ||
| "cart": { | ||
| "name": "ตะกร้าสินค้า", | ||
| "settings": { | ||
| "add_to_cart_behavior": { | ||
| "label": "ประเภทตะกร้าสินค้า", | ||
| "go_to_cart": { | ||
| "label": "หน้า" | ||
| }, | ||
| "cart_notification": { | ||
| "label": "การแจ้งเตือนแบบป๊อปอัพ" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "sections": { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could move this right after the
this.handleErrorMessage();so we still notify the user on the product page if there isn't more of this product ?Here is some errors I noticed on the cart while testing it: video. But Let me know in case it was just local issues.
There seem to be an issue coming from dynamic checkout buttons 🤔 on the cart page: screenshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the first issue with the cart error, I'm thinking it might be a local environment issue (or a bug that came from elsewhere) since I didn't change any of the actual cart JS.
For the second issue, I'm wondering if we should do anything to change that... my thought is, the merchant is looking to effectively take the user right to the cart page and if we were to show an error on the product page, then that would mean we're still making an AJAX call and then sending them there only if there's a success. This will slow things down a lot compared to what I'm doing right now which is effectively just submitting the form (basically the
no-jsflow).I do find it interesting that the cart can't auto-adjust though, but I wonder if that's a limitation of the Liquid API. Like when you go to the cart page, it would make sense for the Liquid to have an awareness that the total quantity is higher than the available quantity. Because again, if the Liquid doesn't have that available, it's another situation where we'd need to make the check on the cart page when the page load via AJAX and then make adjustments. This also goes against one of our theme development principles of "don't do DOM adjustments prior to user input".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's kind of an odd situation. I think that if I can't add the product to the cart because there is none left/I've added them all already, then don't take me to the cart. Let me know on the spot rather than make me wait and load a new page to tell me that 🤔
It's kind of like a frustrating flow there was with recaptcha where sometimes you'd need to go through captcha verification to just be told the email was already registered or something. Ideally if something is wrong or can't be done, don't make me wait and tell me right away.
My 🪙 🪙 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the problem is just that it would cause a delay in all of the cases where the action is valid since we'd need to do a round-trip AJAX call and then redirect to the cart anyway. Since the checkout itself can correct this, I think it makes sense for us to leave this behaviour in because the alternative is too clunky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add more logic in here then.
So that if
this.dataset.addToCartBehavior == 'go_to_cart'is true we run a check on the product quantity available before going to the cart page with a fetch 🤔