-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to polaris 11 and react 18 #72
Conversation
I have signed the CLA! |
Thank you for this PR. |
@pnmcosta Have approved the workflow run, looks like there are still some issues to resolve. LMK if you run into any problems resolving them and I can look into it :) |
Hi @mathiusj thank you so much for this. I am currently on holiday and will return next week, but just quickly scanning the details of the error, seems to be something related to linting and its config. Is this something you could help me with? I'm also not clear what the Changelog issue is, am I meant to have a separate tool installed locally to generate the changelog or some sort of manual process? Thank you for you help |
@pnmcosta I have grabbed your forked repo and merged it with a branch in the main repo, and will continue the progress there while you're away, following with this pull request. I'll update the changelog and fix lint errors and request reviews internally to get this going ASAP. Enjoy your vacation!! 🙏 we got this for ya 🥂 You should be able to close this one now 😄 |
Hi @mathiusj thank you for taking my work and making sure the repo is updated! I don't see any mention of it on https://github.com/Shopify/discount-app-components/blob/main/CHANGELOG.md can you confirm this now works with React 18 and Polaris 11? |
I have a hard dependency on this package and have to upgrade both polaris and react to latest on my app, which breaks.
This PR is a work in progress and aims to fix that.So far have been able to:yarn build
*had to change the build verify assertion - probably due to build on different runners.I could not test with Jest, hoping the CI pipeline will throw any issues to resolve.