chore: replace Node.parentNode.removeChildren(Node) by Node.remove()

Shopify · Jun 26, 2022 · 6492a00 · 6492a00
1 parent c7a18c5
commit 6492a00
Show file tree

Hide file tree

Showing 13 changed files with 13 additions and 13 deletions.
diff --git a/src/Draggable/Plugins/Focusable/tests/Focusable.test.js b/src/Draggable/Plugins/Focusable/tests/Focusable.test.js
@@ -27,7 +27,7 @@ describe('Focusable', () => {
 
   afterEach(() => {
     draggable.destroy();
-    sandbox.parentNode.removeChild(sandbox);
+    sandbox.remove();
   });
 
   it('is included by default', () => {

diff --git a/src/Draggable/Plugins/Mirror/Mirror.js b/src/Draggable/Plugins/Mirror/Mirror.js
@@ -258,7 +258,7 @@ export default class Mirror extends AbstractPlugin {
     this.draggable.trigger(mirrorDestroyEvent);
 
     if (!mirrorDestroyEvent.canceled()) {
-      this.mirror.parentNode.removeChild(this.mirror);
+      this.mirror.remove();
     }
   }
 

diff --git a/src/Draggable/Plugins/Mirror/tests/Mirror.test.js b/src/Draggable/Plugins/Mirror/tests/Mirror.test.js
@@ -45,7 +45,7 @@ describe('Mirror', () => {
 
   afterEach(() => {
     draggable.destroy();
-    sandbox.parentNode.removeChild(sandbox);
+    sandbox.remove();
   });
 
   it('creates mirror element on `drag:start`', async () => {

diff --git a/src/Draggable/Sensors/DragSensor/tests/DragSensor.test.js b/src/Draggable/Sensors/DragSensor/tests/DragSensor.test.js
@@ -43,7 +43,7 @@ describe('DragSensor', () => {
 
   function teardown() {
     dragSensor.detach();
-    sandbox.parentNode.removeChild(sandbox);
+    sandbox.remove();
   }
 
   describe('common', () => {

diff --git a/src/Draggable/Sensors/MouseSensor/tests/MouseSensor.test.js b/src/Draggable/Sensors/MouseSensor/tests/MouseSensor.test.js
@@ -42,7 +42,7 @@ describe('MouseSensor', () => {
 
   function teardown() {
     mouseSensor.detach();
-    sandbox.parentNode.removeChild(sandbox);
+    sandbox.remove();
   }
 
   describe('common', () => {

diff --git a/src/Draggable/Sensors/TouchSensor/tests/TouchSensor.test.js b/src/Draggable/Sensors/TouchSensor/tests/TouchSensor.test.js
@@ -34,7 +34,7 @@ describe('TouchSensor', () => {
 
   function teardown() {
     touchSensor.detach();
-    sandbox.parentNode.removeChild(sandbox);
+    sandbox.remove();
   }
 
   describe('common', () => {

diff --git a/src/Draggable/tests/Draggable.test.js b/src/Draggable/tests/Draggable.test.js
@@ -37,7 +37,7 @@ describe('Draggable', () => {
   });
 
   afterEach(() => {
-    sandbox.parentNode.removeChild(sandbox);
+    sandbox.remove();
   });
 
   describe('.Plugins', () => {

diff --git a/src/Droppable/tests/Droppable.test.js b/src/Droppable/tests/Droppable.test.js
@@ -47,7 +47,7 @@ describe('Droppable', () => {
 
   afterEach(() => {
     droppable.destroy();
-    sandbox.parentNode.removeChild(sandbox);
+    sandbox.remove();
   });
 
   describe('triggers', () => {

diff --git a/src/Plugins/ResizeMirror/tests/ResizeMirror.test.js b/src/Plugins/ResizeMirror/tests/ResizeMirror.test.js
@@ -62,7 +62,7 @@ describe('ResizeMirror', () => {
 
   afterEach(() => {
     draggable.destroy();
-    sandbox.parentNode.removeChild(sandbox);
+    sandbox.remove();
   });
 
   it('resizes mirror based on over element', async () => {

diff --git a/src/Sortable/tests/Sortable.test.js b/src/Sortable/tests/Sortable.test.js
@@ -58,7 +58,7 @@ describe('Sortable', () => {
 
   afterEach(() => {
     sortable.destroy();
-    sandbox.parentNode.removeChild(sandbox);
+    sandbox.remove();
   });
 
   it('triggers events', () => {

diff --git a/src/Swappable/Swappable.js b/src/Swappable/Swappable.js
@@ -153,7 +153,7 @@ export default class Swappable extends Draggable {
 function withTempElement(callback) {
   const tmpElement = document.createElement('div');
   callback(tmpElement);
-  tmpElement.parentNode.removeChild(tmpElement);
+  tmpElement.remove();
 }
 
 function swap(source, over) {

diff --git a/src/Swappable/tests/Swappable.test.js b/src/Swappable/tests/Swappable.test.js
@@ -58,7 +58,7 @@ describe('Swappable', () => {
 
   afterEach(() => {
     swappable.destroy();
-    sandbox.parentNode.removeChild(sandbox);
+    sandbox.remove();
   });
 
   it('triggers events', () => {

diff --git a/src/shared/utils/closest/tests/closest.test.js b/src/shared/utils/closest/tests/closest.test.js
@@ -19,7 +19,7 @@ describe('utils', () => {
   });
 
   afterEach(() => {
-    sandbox.parentNode.removeChild(sandbox);
+    sandbox.remove();
   });
 
   it('should return null when no element specified', () => {