Update upath to support node 10 #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @om3n07 sorry for the late reply. We generally let I was hoping to take some time this weekend to tackle that update and get everything working for the latest version of node. So, I'll hold off on this PR for now until I get the chance to properly look into this. Sorry for the inconvenience 😢 I hope this hasn't been too much of a pain for you. |
|
No worries, understood. Thanks! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements or fixes
After cloning, when attempting to run
yarn start, would receive this error:error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9".Note that I have Node.js v10.0.0 installed on my machine.
Looks like upath@1.0.5 addresses this as per this issue:
anodynos/upath#14