This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Turn off prefer-destructuring #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismail-syed
force-pushed
the
turn-off-prefer-destructuring
branch
from
66cf7e9
to
eae6f98
Compare
lemonmade
approved these changes
May 29, 2017
|
Was this causing problems? |
|
Yes, it seemed to want you to destructure at every level of dot notation in an object, and was doing the wrong thing for numbered keys (wanting you to object-destructure them), and seemingly wanted it for places it is invalid, like using keys that are just variables or for keys that are strings that would not make valid identifiers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.