Possible stableId collision when scrolling too fast

[madmeatballs]

Current behavior

Using MasonryFlashList when scrolling too fast it results to "Possible stableId collision" then leaves a large blank space until it continues to show my product cards. (Data comes from an API, which has offset pagination, onEndReached it is called to update the list.)

Expected behavior

no "Possible stableId collision", list should render accordingly without any issues.

To Reproduce

Scroll too fast.

Platform:

• iOS
• Android

Environment

"@shopify/flash-list": "^1.4.0",
"react-native": "0.68.5",

[hirbod]

Usually this issue happens only if you really have duplicate content. Are you using a key extractor? If yes, try to use the index or omit it when you are not animating. In my cases, keyextractor never changed anything significant performance wise. If that issue still persists, the issue might come through pagination. I had a case, where the data in my database changed while I was paginating, so items, which had be on page 1, shifted and ended up being on the second page, causing an exact duplicate. The best fix for scenarios is a date limit field or just a data transformer which removes duplicates.

[fortmarek]

As @hirbod mentioned, it's unlikely that the stableId collision occurs due to the fast scrolling. You can try to reproduce this in our fixture app and we can take a look 🙂

[madmeatballs]

Will checkout my data, thanks for the feedback @hirbod @fortmarek

[ngdbao]

i'm experiencing this issue too.
For my case, Flashlist always have 1 init call (skip 0 take 10) and 1 pre-load (*) loadmore call (skip 10 take 10) at the first time load even not scrolling at all, regardless of setting onEndReachedThreshold or not

then, If i scroll down fast enough, it will trigger 1 loadmore call with exactly same (skip 10 take 10) pre-load call, which causing "Possible stableId collision"

So problem in my case is (*) pre-load loadmore call where onEndReachedThreshold doesnt work as expected at any value or null

                <AppView flex backgroundColor={PALETTE_COLOR.light}>
                    <FlashList
                        estimatedItemSize={70}
                        showsVerticalScrollIndicator={false}
                        numColumns={1}
                        onScroll={onScroll}
                        data={dataFeaturesTrips || []}
                        renderItem={renderItem}
                        keyExtractor={keyExtractor}
                        onMomentumScrollBegin={onMomentumScrollBegin}
                        onEndReached={onEndReached}
                        onEndReachedThreshold={0.1}
                        refreshControl={
                            <RefreshControl
                                refreshing={refreshing}
                                onRefresh={onRefresh}
                                tintColor={PALETTE_COLOR.primary}
                                colors={[
                                    PALETTE_COLOR.orange[300],
                                    PALETTE_COLOR.orange[500],
                                    PALETTE_COLOR.orange[700],
                                ]}
                            />
                        }
                        ListEmptyComponent={
                            <AppView alignCenter>
                                <AppText
                                    style={[
                                        STYLE_GLOBAL.body1,
                                        STYLE_GLOBAL.weight600,
                                        STYLE_GLOBAL.color_textcontent,
                                    ]}>
                                    Waiting...
                                </AppText>
                            </AppView>
                        }
                        ListHeaderComponent={
                            <SafeAreaView
                                edges={['top']}
                                style={[styles.scrollView]}>
                                <HeaderSection
                                    marginBottom={4}
                                    hiddenCategories
                                    oneLine
                                    isFromHome={false}
                                />
                            </SafeAreaView>
                        }
                        ListFooterComponent={
                            <AppView paddingBottom={getSize.m(48)} />
                        }
                    />
                </AppView>

if i change "FlashList" to "FlatList", problem gone.

[ngdbao]

i'm experiencing this issue too. For my case, Flashlist always have 1 init call (skip 0 take 10) and 1 pre-load (*) loadmore call (skip 10 take 10) at the first time load even not scrolling at all, regardless of setting onEndReachedThreshold or not

turn out it's about estimatedItemSize too small, 300 is fitting for me now

[efstathiosntonas]

What I did and I've never encountered the stableId collision again is to add the index to the keyExtractor like so:

 const keyExtractor = useCallback((item: any, i: number) => `${i}-${item.id}`, []);

I was constantly having issues with it since my list is 100% real-time but now the issues are gone. Can't explain why adding the index fixes it, it seems it works automagically now 🤷

[chj-damon]

What I did and I've never encountered the stableId collision is to add the index to the keyExtractor like so:

 const keyExtractor = useCallback((item: any, i: number) => `${i}-${item.id}`, []);

I was constantly having issues with it since my list is 100% real-time but now the issues are gone. Can't explain why adding the index fixes it, it seems it works automagically now 🤷

you saved my day!

[hlspablo]

What I did and I've never encountered the stableId collision again is to add the index to the keyExtractor like so:

 const keyExtractor = useCallback((item: any, i: number) => `${i}-${item.id}`, []);

I was constantly having issues with it since my list is 100% real-time but now the issues are gone. Can't explain why adding the index fixes it, it seems it works automagically now 🤷

just as additional info, this code prevents key duplication at all, since it combines the id and index, but the warning should not be blindly ignored since it can be a sign of a bug in the pagination.

[MichalKrakow]

How about basic array splice, same story:

comments.splice(index, 1);
setComments([...comments]);

produces "Possible stableId collision" even though the index in question is clearly gone.
Index extractor relyes on comment.id so it has zero chance of reocurring after delete.

I mean... it is a warning rather then error and its says "possible". After multiple tests it didnt produce any unwanted behaviour but im left with impression im doing something wrong.

Someone faced the same thing?

[hlspablo]

How about basic array splice, same story:

comments.splice(index, 1);
setComments([...comments]);

produces "Possible stableId collision" even though the index in question is clearly gone. Index extractor relyes on comment.id so it has zero chance of reocurring after delete.

I mean... it is a warning rather then error and its says "possible". After multiple tests it didnt produce any unwanted behaviour but im left with impression im doing something wrong.

Someone faced the same thing?

its very likely that you are doing something "wrong", what you mean with clearly gone?!

[MichalKrakow]

Ok some basic JS magic behind the scenes that probably i should be aware of.

const newList = [...comments];
newList.splice(index, 1);
setComments(newList);

this does not raise warnings upon item removal.
Copying the list priror to modification solved the issue.

[hyochan]

What I did and I've never encountered the stableId collision is to add the index to the keyExtractor like so:

 const keyExtractor = useCallback((item: any, i: number) => `${i}-${item.id}`, []);

I was constantly having issues with it since my list is 100% real-time but now the issues are gone. Can't explain why adding the index fixes it, it seems it works automagically now 🤷

you saved my day!

I think if you don't use useCallback, the keyExtractor function gets recreated during each re-render in React. This can cause the keys returned by keyExtractor to be inconsistent. Specifically, when this function is frequently regenerated, there’s a possibility that the same item might receive different keys between previous and current renders. As a result, the consistency of keys isn't maintained, leading React to potentially misidentify the same item as different ones. This inconsistency can trigger the "stableId collision" warning.