Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inverted horizontal list performance laggy #851

Merged

Conversation

SherifMega
Copy link
Contributor

Description

Fixes Inverted Horizontal List Performance Laggy
cc: @naqvitalha @fortmarek

Reviewers’ hat-rack 🎩

  • [ ]

Screenshots or videos (if needed)

Before After
https://github.com/Shopify/flash-list/assets/32880766/a85f91dc-5c2b-4496-83f0-b508c565eb79 https://github.com/Shopify/flash-list/assets/32880766/df0c11d6-8855-4d31-a52a-ff118ccc3d36

Checklist

@SherifMega SherifMega force-pushed the fix-horizontal-inverted-list-performance branch from d6b5fa8 to f664c09 Compare June 1, 2023 10:32
@SherifMega SherifMega changed the title fix inverted horizontal list performance fix inverted horizontal list performance laggy Jun 1, 2023
@naqvitalha
Copy link
Collaborator

@SherifMega Any luck finding solution to the scrollbar? It'll move to top of the list. The one inverted vertically has the same problem.

@SherifMega
Copy link
Contributor Author

@SherifMega Any luck finding solution to the scrollbar? It'll move to top of the list. The one inverted vertically has the same problem.

I didn't check that but may be we need to look at that separately 🤷‍♂️

@naqvitalha naqvitalha merged commit e2854a5 into Shopify:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants