Downgrade temporary net.Error to warning #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sharedstore is meant to gracefully degrade when the shared lock is not available. As such, a temporary connection issue like timeouts is not worthy of logging at the Error level.
lavoiesl
force-pushed
the
seb-warn-temporary-errors
branch
from
f582e28
to
27bfafa
Compare
lugray
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sharedstore is meant to gracefully degrade when the shared lock is not available.
As such, a temporary connection issue like timeouts is not worthy of logging at the Error level.
To allow this, recreate a
net.OpErrorfrom the potentialmemcache.ConnectTimeoutErrorsuch that it can be properly detected as a temporary error.Note that memcache can still generate regular
i/o timeouterrors, which are propernet.Erroralready.