Fix golint complaints, use filepath instead of path, add color to README.
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change path to filepath. `path` is not specific to filesystem paths, while `filepath` is. Also "./data" can be changed to "data" to make it portable.
|
cc @mkobetic |
| ) | ||
|
|
||
| // Indirect is a referrer that doesn't match any of the other referrer types. | ||
| type Indirect struct { | ||
| Url string // original referrer URL | ||
| URL string // original referrer URL |
There was a problem hiding this comment.
We prefer Url notation even for abbreviations :)
|
@aybabtme hmm ok I see that golint was complaining about the refUrl notation, stick with |
|
Confirmed that tests are 🍏, we can |
when 
|
@snormore I also prefer |
|
👍 Thanks! |
snormore
added a commit
that referenced
this pull request
Nov 22, 2013
Fix `golint` complaints, use `filepath` instead of `path`, add color to README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've made a few simple changes, mostly replacing usages of
pathforfilepathfor filesystem related path manipulation; sincepathis not portable across OS. Also I've fixed the issuesgolintwas reporting. If you don't usegolint, you can find it here:https://github.com/golang/lint
Finally I've set the example code in the README to use Go syntax highlighting.