Use trace_with to start and end batches #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like GraphQL-Ruby doesn't support Ruby 2.4 anymore 😅 |
5 tasks
|
Fixed in #165 |
|
Thanks, I merged master into this branch 👍 |
|
@swalkinshaw thank you very much. Do you plan to release this in a new version? That would be extremely helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping to consolidate GraphQL-Ruby's many instrumentation hooks in GraphQL-Ruby 3.0 (someday). I'm hoping to add a deprecation warning to
instrument(...)in the next release (rmosolgo/graphql-ruby#4771),trace_withis sufficient for those cases.This PR moves GraphQL-Batch's hooks to
trace_with, what do you think of that?