Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup not working as of #164 #169

Closed
eapache-opslevel opened this issue Feb 23, 2024 · 1 comment
Closed

Setup not working as of #164 #169

eapache-opslevel opened this issue Feb 23, 2024 · 1 comment

Comments

@eapache-opslevel
Copy link

eapache-opslevel commented Feb 23, 2024

👋 @rmosolgo I'm trying to upgrade 0.5.3 -> 0.5.4 of this gem locally, which pulls in your change in #164.

I'm now getting the following error whenever a query tries to batch load:

Cannot create loader without an Executor. Wrap the call to for with GraphQL::Batch.batch or use GraphQL::Batch::SetupMultiplex as a query instrumenter if using with graphql-ruby

Looking at the full backtrace, I no longer see graphql-batch code in there anywhere, so presumably the new GraphQL::Batch::SetupMultiplex::Trace is not getting triggered for some reason.

Our schema class still has use GraphQL::Batch at the bottom, so I'm not sure what's going on. I'll keep looking to see why it's not getting wrapped properly.

(this is with graphql-ruby 2.1.11, ruby 3.2.2, rails 7.1.3)

@eapache-opslevel
Copy link
Author

OK, this has to do with our use of trace modes... not sure if the bug is in our code or in graphql-ruby, but it's not in graphql-batch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant