Allow a custom executor class in GraphQL::Batch.batch
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Policial doesnt seem to know |
|
I don't think Policial should even be checking this repo, since there is no rubocop config file, in which I would otherwise suggest that we just ignore the cop. I've changed the Policial settings for the repo to not check ruby files. |
test/batch_test.rb
Outdated
| @@ -8,6 +8,29 @@ def test_batch | |||
| assert_equal 'Shirt', product.title | |||
| end | |||
|
|
|||
| class MyCustomExecutor < GraphQL::Batch::Executor | |||
There was a problem hiding this comment.
I would prefer if you moved the new test to GraphQL::Batch::CustomExecutorTest so that we can use the MyCustomExecutor in there rather than copying it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #68
Would be great to be able to use this using the
GraphQL::Batch.batchAPI. WDYT?cc @chrisbutcher