Fix discount route (#601)

* Fix discount route * Changeset
Shopify · Mar 1, 2023 · d8821f8 · d8821f8
1 parent adef0fc
commit d8821f8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/tall-falcons-punch.md b/.changeset/tall-falcons-punch.md
@@ -0,0 +1,5 @@
+---
+'@shopify/cli-hydrogen': patch
+---
+
+Fix `check routes` command to correctly check the standard route `/discount/<code>` instead of `/discounts/<code>`.
diff --git a/packages/cli/src/utils/missing-routes.ts b/packages/cli/src/utils/missing-routes.ts
@@ -26,7 +26,7 @@ const REQUIRED_ROUTES = [
   //   'variants/:variantId',
   'search',
   //   'gift_cards/:storeId/:cardId',
-  'discounts/:discountCode',
+  'discount/:discountCode',
 
   'account',
   'account/login',

diff --git a/packages/hydrogen/src/seo/generate-seo-tags.test.ts b/packages/hydrogen/src/seo/generate-seo-tags.test.ts
@@ -656,7 +656,7 @@ describe('generateSeoTags', () => {
             offers: [
               {
                 '@type': 'Offer',
-                url: 'hydrogen.shop/discounts/1234',
+                url: 'hydrogen.shop/discount/1234',
               },
             ],
           },

diff --git a/...re/app/routes/($lang)/discounts.$code.tsx → ...ore/app/routes/($lang)/discount.$code.tsx b/...re/app/routes/($lang)/discounts.$code.tsx → ...ore/app/routes/($lang)/discount.$code.tsx
@@ -8,7 +8,7 @@ import {cartCreate, cartDiscountCodesUpdate} from './cart';
  * @example
  * Example path applying a discount and redirecting
  * ```ts
- * /discounts/FREESHIPPING?redirect=/products
+ * /discount/FREESHIPPING?redirect=/products
  *
  * ```
  * @preserve