Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discount route #601

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Fix discount route #601

merged 2 commits into from
Mar 1, 2023

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Mar 1, 2023

The standard route is supposed to be /discount/<code> instead of the existing /discounts/<code>.
The deployed version is now redirecting correctly: deployed-PR/discount/SHIPPING

What's the best way to inform of these changes in the demo-store to existing users?

@frandiox frandiox requested a review from a team March 1, 2023 07:35
Copy link
Contributor

@frehner frehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changeset is a good way to notify. Also, don't we warn devs if they don't have standard routes? So does this update mean that if they have a discounts route they'll now have a new warning about not having a discount route?

@@ -0,0 +1,5 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great file name

@juanpprieto juanpprieto merged commit d8821f8 into 2023-01 Mar 1, 2023
@juanpprieto juanpprieto deleted the fd-fix-discount-route branch March 1, 2023 22:13
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants