General fixes #1128
Merged
General fixes #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blittle
reviewed
Jul 21, 2023
| const isAppLine = (line: string) => line.includes(options.appDirectory); | ||
| const isAppLine = (line: string) => | ||
| line.includes(options.rootDirectory) && | ||
| !line.includes('node_modules'); |
There was a problem hiding this comment.
Does it not work with just the node_modules check?
There was a problem hiding this comment.
It... probably does 🤔
Edit: I forgot why I did it but now I remember -- it should work only with the node_modules check in user apps but not in the monorepo where part of the stack comes from packages/hydrogen 😅
blittle
reviewed
Jul 21, 2023
Comment on lines
+86
to
+91
| You’re seeing this because you don’t have a home route | ||
| in your project yet. <br /> | ||
| Run <code>h2 generate route home</code> to create your home route. | ||
| Learn more about | ||
| {` `} | ||
| <CreateRoutesLink /> |
blittle
approved these changes
Jul 21, 2023
This was referenced Jul 21, 2023
Closed
Merged
FrcPpe
pushed a commit
to FrcPpe/hydrogen
that referenced
this pull request
Aug 13, 2023
* Remove log related to .shopify in .gitignore * Update list prompt and cleanup * Throw error in HR when storeDomain is falsy * Trim stack trace for every known error, not only GraphQL * Show server.ts in stack trace and ensure something is shown * Fix tests * Update HR error messages * Improve virtual-route information when store is linked * Use mock.shop in hello-world * Changesets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor fixes, check commits 1 by 1 since they are independent.
The main change is starting to use mock.shop in
hello-world. I think this makes sense because that's the template that new storefronts created from Admin will use. This way, it's more similar to skeleton.