-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General fixes #1128
Merged
Merged
General fixes #1128
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
74b44cf
Remove log related to .shopify in .gitignore
frandiox 8d76581
Update list prompt and cleanup
frandiox 71b1eb4
Throw error in HR when storeDomain is falsy
frandiox 1689784
Trim stack trace for every known error, not only GraphQL
frandiox 52c8b98
Show server.ts in stack trace and ensure something is shown
frandiox d61290f
Fix tests
frandiox c59a2f4
Update HR error messages
frandiox 63b5b0c
Improve virtual-route information when store is linked
frandiox 42e5f87
Use mock.shop in hello-world
frandiox 895963c
Changesets
frandiox File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@shopify/hydrogen-react': patch | ||
'@shopify/hydrogen': patch | ||
--- | ||
|
||
Throw error when `storeDomain` is not passed to `createStorefrontClient`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,12 +71,26 @@ export default function Index() { | |
{configDone ? <HydrogenLogoBaseColor /> : <HydrogenLogoBaseBW />} | ||
<h1>Hello, {shopName}</h1> | ||
<p>Welcome to your new custom storefront</p> | ||
{configDone ? null : ( | ||
<section className="Banner"> | ||
<div> | ||
<IconBanner /> | ||
<h2>Configure storefront token</h2> | ||
</div> | ||
|
||
<section className="Banner"> | ||
<div> | ||
<IconBanner /> | ||
<h2> | ||
{configDone | ||
? 'Create your first route' | ||
: 'Configure storefront token'} | ||
</h2> | ||
</div> | ||
{configDone ? ( | ||
<p> | ||
You’re seeing this because you don’t have a home route | ||
in your project yet. <br /> | ||
Run <code>h2 generate route home</code> to create your home route. | ||
Learn more about | ||
{` `} | ||
<CreateRoutesLink /> | ||
Comment on lines
+86
to
+91
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So much better |
||
</p> | ||
) : ( | ||
<p> | ||
You’re seeing this because you have not yet configured your | ||
storefront token. <br /> | ||
|
@@ -95,23 +109,28 @@ export default function Index() { | |
</a> | ||
{` `} | ||
and{` `} | ||
<a | ||
target="_blank" | ||
rel="norefferer noopener" | ||
href="https://shopify.dev/docs/custom-storefronts/hydrogen/building/begin-development#step-4-create-a-route" | ||
> | ||
creating routes | ||
</a> | ||
. | ||
<CreateRoutesLink />. | ||
</p> | ||
</section> | ||
)} | ||
)} | ||
</section> | ||
<ResourcesLinks /> | ||
</Layout> | ||
</> | ||
); | ||
} | ||
|
||
function CreateRoutesLink() { | ||
return ( | ||
<a | ||
target="_blank" | ||
rel="norefferer noopener" | ||
href="https://shopify.dev/docs/custom-storefronts/hydrogen/building/begin-development#step-4-create-a-route" | ||
> | ||
creating routes | ||
</a> | ||
); | ||
} | ||
|
||
function ErrorPage() { | ||
return ( | ||
<> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
# The variables added in this file are only available locally in MiniOxygen | ||
# These variables are only available locally in MiniOxygen | ||
|
||
SESSION_SECRET="foobar" | ||
PUBLIC_STOREFRONT_API_TOKEN="3b580e70970c4528da70c98e097c2fa0" | ||
PUBLIC_STORE_DOMAIN="hydrogen-preview.myshopify.com" | ||
PUBLIC_STORE_DOMAIN="mock.shop" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it not work with just the
node_modules
check?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It... probably does 🤔
Edit: I forgot why I did it but now I remember -- it should work only with the node_modules check in user apps but not in the monorepo where part of the stack comes from
packages/hydrogen
😅