fix aside scroll for larger pages #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should I add an empty commit to try to rerun the checks? |
|
@QuentinGibson add a changeset |
|
I do! Let me get on it.
…On Tue, Aug 1, 2023, 9:49 AM Bret Little ***@***.***> wrote:
@QuentinGibson <https://github.com/QuentinGibson> add a changeset npm run
changeset add if you'd like credit in the release notes.
—
Reply to this email directly, view it on GitHub
<#1163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEBMFAE5HBC6KFPHFKIGRXTXTECNXANCNFSM6AAAAAA22R3FHU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
|
blittle
reviewed
Aug 1, 2023
blittle
reviewed
Aug 1, 2023
Merged
FrcPpe
pushed a commit
to FrcPpe/hydrogen
that referenced
this pull request
Aug 13, 2023
* fix aside scroll for larger pages --------- Co-authored-by: Bret Little <bret.little@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve aside area to scroll with view
WHY are these changes introduced?
Fixes #0000
#1162
WHAT is this pull request doing?
A small css change. The container for the "overlay button" position is set to fixed instead of absolute.
HOW to test your changes?
Post-merge steps
Checklist