Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix product search results header style #1405

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix product search results header style #1405

merged 2 commits into from
Oct 9, 2023

Conversation

tatsuya
Copy link
Contributor

@tatsuya tatsuya commented Oct 6, 2023 •
edited
Loading

WHY are these changes introduced?

Fixes the header style of the "Products" in the search result page to align with other sibling headers (e.g. "Articles")

Screenshot 2023-10-06 at 1 27 38 PM

WHAT is this pull request doing?

One line html tag change

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@tatsuya tatsuya marked this pull request as ready for review October 6, 2023 18:16
@juanpprieto juanpprieto merged commit cf5fe84 into main Oct 9, 2023
9 checks passed
@juanpprieto juanpprieto deleted the fix-product-search-results-header-style branch October 9, 2023 18:20
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpprieto juanpprieto juanpprieto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tatsuya @juanpprieto